feat: bump typed-express-router to 2.0.0 #109
Conversation
|
@starfy84 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs. I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review. |
|
@copilot redo this, we just need to update package.json with the new version, update package-lock.json with the updated package, and potentially modify code |
Done! I've updated the approach to focus only on the essential changes:
The package upgrade is complete and working correctly. See commit 2c31359. |
starfy84
force-pushed
the
copilot/fix-108
branch
from
2c31359 to
2b7ae43
Compare
starfy84
force-pushed
the
copilot/fix-108
branch
from
2b7ae43 to
357240c
Compare
starfy84
force-pushed
the
copilot/fix-108
branch
from
357240c to
0d082d9
Compare
starfy84
requested review from
a team,
adityasoni-bitgo and
satyamkotikalapudi
and removed request for
a team
kaustubhbitgo
requested review from
mohammadalfaiyazbitgo and
pranavjain97
and removed request for
adityasoni-bitgo and
satyamkotikalapudi
|
Flushing reviews! |
This PR upgrades
@api-ts/typed-express-routerfrom version^1.1.13to2.0.0to take advantage of the latest features and improvements in the typed Express router library.Changes
@api-ts/typed-express-routerdependency from^1.1.13to^2.0.0inpackage.jsonpackage-lock.jsonwith all updated dependenciesAnalysis
After analyzing the codebase, I found that:
5 files use
createRouterfrom@api-ts/typed-express-router:src/advancedWalletManager/routers/advancedWalletManagerApiSpec.tssrc/advancedWalletManager/routers/healthCheck.tssrc/api/master/routers/awmExpressHealth.tssrc/api/master/routers/healthCheck.tssrc/api/master/routers/masterBitGoExpressApiSpec.tsAll required exports remain available:
createRouter,TypedRequestHandler, andWrappedRouterare all present in v2.0.0.The upgrade is straightforward since we only use the basic router creation functionality and don't rely on any of the deprecated error handling patterns.
Fixes #108.
Ticket: DX-1672
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.